Who was it that suggested the "Principle of Least
Surprise" for component behaviour? I'd say this is
a rather gross violation of that rule. Sure, it's
great to tell the programmer that they may have
called the function improperly, but to die
on ill-formed input, especially in a function that's
supposed to check for validity, is extreme. (By all
means carp about strange input -- bonus
points if you provide a flag for debugging output,
so that end users don't have to wade through a huge
cascade of "hey, programmer, I think you've messed
up" messages from a smart-ass module.)
As an aside, I can't stand the name
'check_date' for that function. Okay, it
checks the date, but what does it do after checking
the date? Die with an error? Return true ("yes,
it's valid")? Return false ("yes, it's bogus")?
Set a flag somewhere? How about is_valid_date
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||