Comment on

Simple patch to improve robust handling of node titles with funky characters, such as Ö, Ä, Ü and XML::Simple. Without binary mode this trips up the Text::CSV_XS read and write methods.

Matt

--- xluke_repwalker.old.pl      Thu May  9 01:24:40 2002
+++ xluke_repwalker.pl  Thu May  9 01:24:35 2002
@@ -362,7 +362,8 @@
    defined ($fh) or croak "Can't open file \'$filename\": $!";

    my $csv = Text::CSV_XS->new ({'always_quote' => 1,
-                                 'eol'          => "\n"
+                                 'eol'          => "\n",
+                                 'binary'       => 1,
                                 });

    while (<$fh>)
@@ -397,7 +398,8 @@
    defined ($fh) or croak "Can't create file \"$filename\": $!";

    my $csv = Text::CSV_XS->new ({'always_quote' => 1,
-                                 'eol'          => "\n"
+                                 'eol'          => "\n",
+                                 'binary'       => 1,
                                 });

    for (sort {$a <=> $b} keys %$nodehash)
[download]

In reply to Re: xluke_repwalker.pl by mojotoad
in thread xluke_repwalker.pl by jcwren

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.


Think about Loose Coupling
	PerlMonks