Excellent post (especially for a starter), Nuke! :)

To start, let me welcome you to the Monastery. It is my sincere pleasure to see you have found the courage to set out on the glorious passage of sainthood!

I think your post is a perfect fit for the Perl Monks Discussion forum since you are really trying to discuss a given subject here rather than ask a plain Perl coding question.

You have picked a nice set of code review levels. But I also feel that it still lacks a few pieces. For example, at my work, we also check for ways how a piece of code that is up for a review could be 'refactored'. This is very much in line with a fabulous discussion you can find here and also here. Of course, we also give top priority to script security, especially if it's a web script. For server side scripts only, which are not directly accessible through a web server, there are other things to look at.

First, if script is running as a daemon, we normally look closely at hot spots which could cause memory leaks or grind the entire system to a virtual hault by taking over CPU (the script should run at appropriate 'nice' levels...)

Secondly, in our code reviews, we consider how a given script is handling files etc. For example, if file locking is required, is it being done properly in the code?

UPDATE: I don't have any more votes left for today, but I'll make sure to give your post a ++ tomorrow! ;-)

UPDATE 1: Oops, was this thread moved to Perl Monks Discussions from it's initial Seekers of Perl Wisdom spot, or do I suffer late night migraine? ;)

UPDATE 2: Ahh, just found it out from andreycheck that I'm apparently a perfectly normal human being; a monk, but still in good spiritual health. Thanks guys for moving the post as I too felt it would be the right thing to do :p

_____________________

$"=q;grep;;$,=q"grep";for(`find . -name ".saves*~"`){s;$/;;;/(.*-(\d+)
+-.*)$/;$_=&#91"ps -e -o pid | "," $2 | "," -v "," "]`@$_`?{print"
++ $1"}:{print"- $1"}&&`rm $1`;print"\n";}
[download]

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.