A few comments after a quick scan through the code:
- I'm not sure how you are supposed to install this
as a Win32 service (The supplied subs, "Remove", "Install", etc.
don't seem to have anything pointing to them).
- Some of this code looks like it should be refactored:
e.g. the code for minutos and horas are almost identical,
and with some re-writing you could have much simpler
- You're not useing strict or warnings!
- The name of the crontab file is hard-coded in the
script. You should probably document that!
- (And you should probably document that the names of
the days are hard-coded in Spanish, and where to change
them. If you've not learned how to use POD documentation
try reading the perlpod manpage, very useful!)
Hope that helps.
In reply to Re: Crond
in thread Crond
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||