Of course, the canonical reply would be to use CGI.pm which handles all of this nasty stuff quite well and comes with about every Perl distribution I know. CGI.pm also takes care of the tempfile creation, removal and I guess that there are no backdoors or exploits in CGI.pm itself.

There are at least two things wrong with the code :
First, no error checking. Opening a file should always be done like this (in my holy opinion) :

  local *FILE;
  open( FILE,  "> $file" ) or die "Couldn't create '$file' : $!\n";
  ...
  close( FILE );
[download]

Of course, it's not always adequate to die(), but at least a warn is in place and for tools or CGI stuff, a die isn't bad, as the stuff will show up in the error log of the server.

The second thing is, that the file will be clobbered under Win32, as it is used for binary data and no binmode() is used on the file handle. This will not affect writing ASCII data in any way and it will also have no effect under UNIX platforms.

Looking further through the code, I see that $form_data is printed to STDOUT instead of (as it maybe should be ?) to FILE. Maybe that's already the error... Also, because there won't be more (or less) bytes available on STDIN than $ENV{'CONTENT_LENGTH'} indicates, reading from STDIN could simply be done by using the following code :

{
  local $/ = "";
  $form_data = <>;
};

# $form_data now contains the submitted stuff
[download]

But I would really use CGI.pm for such stuff like file submission !

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.