Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
What is the semantics of del_attr('font') on a start tag when the attr is missing? Does it croak or "fail" silently?

I.e. does del_attr() guarantee that an attr will be deleted (i.e. the tag modified), or does it guarantee that the attr 'font' will not be in the tag after being run?

If the semantics is focused on the deletion, it's not appropriate to modify a closing tag if a closing tag can't be modified (by removing attributes).

If the semantics is focused on the absence of the attribute after running the method, it's appropriate to leave it to the object to know that "hey, there can't be any attributes here anyway, so I'll let it slide".

Personally, I'd go with the second alternative, since it lays down fewer rules about how to use the class (this method must only be called in this state!) while (meththinks) providing the same functionality.

From the user's perspective, the important thing is probably that the attribute is gone, not that it was deleted.

Now, I don't know anything about HTML::TokeParser::Simple, but is it really impossible for closing tags to have attributes? If passed invalid HTML? If so, is it the responsibility of the class to do anything about it?

In reply to Re: OO style question: how much information to hide? by jplindstrom
in thread OO style question: how much information to hide? by Ovid

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others imbibing at the Monastery: (6)
    As of 2018-01-21 15:56 GMT
    Find Nodes?
      Voting Booth?
      How did you see in the new year?

      Results (228 votes). Check out past polls.