Everyone loves to post bad examples from other peoples' code. But I will [once again] bravely delve into my own code archives for terrible examples!
This is at the beginning of a script that I must have written shortly after I learned about use strict. I didn't really understand lexical scope, I just wanted the errors to go away. Can we say "missing the point"?
my($all,$com,$csv,$ctr,$desc,$dir,$fname,$found,$fsize,
$line,$longline,$null,$one);
my($parm,$parms,$pattern,$seekrc,$value);
my(@coms,@csvin,@grep,@parms,@seekrc);
Here's another fun one. I can think of one or two easier ways to do this nowadays....
($start,$stop,$adv,$desc) = split(/\,/,$line);
$start =~ s/^\s+//g;
$stop =~ s/^\s+//g;
$adv =~ s/^\s+//g;
$desc =~ s/^\s+//g;
Or how about something like this. I guess I didn't yet understand how to access nested hashes, because the use of %temphash is just bizarre (trimmed for pasting):
while(defined($line = <IN>)) {
...
$temphash{'size'} = $size;
$temphash{'crc'} = $crc;
if($dir eq "" || $csvdirs == 1) {
...
$temphash{'dir'} = $good;
} elsif($csvdirs == 2) {
...
$temphash{'dir'} = $good . "/" . $dir;
} else {
$temphash{'dir'} = $dir;
}
$bighash{$name} = { %temphash };
}
I could go on all day, to my own humiliation. I'll leave it at that though. Perhaps others will now be tempted to post their own bad code, rather than someone else's. :-)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.