Beefy Boxes and Bandwidth Generously Provided by pair Networks DiBona
Clear questions and runnable code
get the best and fastest answer
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

Let's compare:

$window->title('foo')->border(20); # versus $window->set(title => 'foo', border => 20);

Clearly, I like method chaining. I use it frequently and my primary argument to people is also "don't use it if you don't want it." However I would never encourage method chaining if the mutator didn't return an object of the same class as the object that received the message (or maybe with an isa relationship and with constructors being a special case). That's just begging Demeter to beat you to death. However, when I look at your code, I see one great big "catch-all" mutator where now I no longer can merely validate the values, but I also have to validate the names of the attributes. It would be easy to type this:

$window->set(title => 'foo', border => 20);

Depending on how someone codes that, it could easily silently fail when a direct method call would not.

I suppose we could argue all day long about which technique is better, but both of our preferred styles have strengths and weaknesses. For now I'll continue to return $self and you can continue to ignore it :)

Cheers,
Ovid

New address of my CGI Course.


In reply to Re^3: Mutator chaining NOT considered harmful by Ovid
in thread Mutator chaining considered harmful by Aristotle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others browsing the Monastery: (10)
    As of 2014-04-16 06:31 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      April first is:







      Results (416 votes), past polls