That is one way to do it, but....
My personal preference is to 'declare' the variable in the scope where it will be used, rather than having a huge clump-o-names at the start of the code. There are at least two reasons for this:
- I don't like leaving variables exposed to the vagaries of later maintenance coders. (Coders, please note, as opposed to programmers.) There is a tendency for Coders to look for an 'unused' variable when they are making enhancements, and grabbing one from the clump at the front is just so tempting. ("Hey, I saved allocating another variable! I'm being Efficient and Reusing code and all that Best Practice Stuff....")
- A clump-o-variables is a strong indication of maintenance headaches to come. That variable you saved in (1), well you changed its value didn't you? And you didn't save the old value so you could restore it after you were done, did you? Your new Code Works, but you have introduced (potentially) bugs in the Old Code that depended on the value in that Global Variable that you just stomped on....
- A clump of declarations makes it harder to figure out where the logic starts, unless you are very very clear with your comments. How many times have I run across my $var;$var=fps(1.234);$mumble=tilde($var);my next_vat; buried in the middle of a bunch of declarations?
- A Clump-O-Variables at the start of your code means you have a Clump-O-Global-Variables. Global variables have 'action at a distance' properties.
use strict; # Note: all in lower case
Don't start coding without it. (And don't start me on that rant
The clump-o-variables (and it's sibling the clump-o-subroutines) is often the hallmark of someone who has written a lot of C or Shell, where you really had to declare before use. The Perl compiler is a little brighter than that. Constructing your code so that it assists in understanding the logic-flow is a good thing. Clumps of things that impede the understanding should be avoided.
That said, the clump-o-something is a valid way to write Code. It's not a style I like, or encourage. But it is a valid style, if it fits your way of seeing the Code. Just bear in mind, if I am the next programmer to do maintenance on this, I may drink an awful lot of coffee before I understand how my fix should fit in. (And a Wired Old Bear is not exactly a pretty sight...)
Fixed broken link; thanks (ysth).
I Go Back to Sleep, Now.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||