comment on

Hi everyone. Is there anyway I can really improve the following small piece of code for a little program that deals with CGI for the internet, where you have a web page that has say 3 links on it leading to other relative pages on the site. When you click on a link you want it to take you to another page and stuff, and it uses the GET command and stuff from the cool CGI.pm parser. In short, I was just wondering how I could improve this code to make it as efficient as I can. It's a really simple little CGI program in Perl, but it's just for a future project of mine, and I would like to know if it needs to be changed around a bit or a lot.

#!/usr/bin/perl -wT
use strict;
use CGI ':all';
use CGI::Carp qw(fatalsToBrowser);

if (param('page') eq "") {
    &index;
}

elsif (param('page') eq "page2") {
    &page2;
}

elsif (param('page') eq "page3") {
    &page3;
}

sub index {
    print header(),
        start_html('INDEX'),    
        '<p>This is the index page!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}

sub page2 {
    print header(),
        start_html('PAGE_2'),    
        '<p>This is page2!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}

sub page3 {
    print header(),
        start_html('PAGE_3'),    
        '<p>This is page3!<br><br>',
        '<a href=index.pl?page=>index</a><br>',
        '<a href=index.pl?page=page2>page2</a><br>',
        '<a href=index.pl?page=page3>page3</a><br>',
        end_html();
}
[download]

Thanks for any help in advance! Bye now.

bladx ~ a seeker of many perl questions

Edit: 2001-03-03 by neshura

In reply to Improving the efficiency of this piece of code by bladx

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


more useful options
	PerlMonks