I dunno about speed, but its the only version i can actualy understand so far ;) and who knows, it might not be as slow as you think...probably will be..but hey! I think the second loop through s2 could probably have some short circuits added where it knows the sub string it is on doesn't occur in the first string..but it's time to go home!
use strict;
use warnings;
use Data::Dumper;
sub common_sub {
my ($s1,$s2,$len) = @_;
my $len_s1 = length($s1);
my $len_s2 = length($s2);
my $match_s1 = {};
my $match_s2 = {};
for my $start (0..length($s1)-1) {
for my $l (1..$len) {
next if $start+$l > $len_s1;
$match_s1->{substr($s1, $start, $l)} ||= 1;
}
}
for my $start (0..length($s2)-1) {
for my $l (1..$len) {
next if $start+$l > $len_s2;
$match_s2->{substr($s2, $start, $l)} ||= 1;
}
}
$match_s1->{$_}++ for keys %$match_s2;
return grep { $match_s1->{$_} == 2 } keys %$match_s1;
}
print join(",", common_sub("ABCD", "BCD",2));
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|