Always check the status of your open
calls! You'll spend less time debugging mysterious errors, I promise.
open (DHCPCMD, "dhcpcmd $DHCPserver enumclients $scope|") || die "Can't get DHCP information: $!";
instead of twodigit():
my $day = sprintf("%02d", localtime->mday);
I'm not sure what comparehashes() is doing, especially as you refer to $1
but don't appear to grab it from anywhere. Instead, I'd lc
() machine names when assigning them to %dhcphash and %dnshash and just use the eq
operator to compare them.
Finally, I like to check the return values of my close() calls. No pun intended. If something goes wrong here, I want to know about it.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
Outside of code tags, you may need to use entities for some characters:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||