You XP whore you!
OK, I have just one comment on the use of XML::Twig
(besides stating that this is how I use it myself
most of the time): if you go through the pain of
putting my ($t, $node) = @_; at the
top of the anonymous sub you might as well use
$node in the body:
NODE => sub { my ($t, $node) = @_;
my $nodeid = $node->att ('id');
!exists ($nodehash {$nodeid}) or croak "N
+ode $nodeid is duplicated!";
$nodehash {$nodeid} = {'nodeid' => $nodei
+d,
'title' => $node-
+>text,
'rep' => $node-
+>att ('reputation'),
'last' => $node-
+>att ('reputation'),
'date' => $node-
+>att ('createtime')
};
$t->purge;
}
Also I found that -h does not work (-? does,
you should check $args{h} on line 87, and I usually
use $0 instead of hard-coding the name of the script
in usage().
Good job anyway, it seems to be much faster than the previous version,
4 to 5 times faster actually!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|