Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

I'm busy creating new functionality for a Web site and I was asked to look at a similar page on the site and "modify" its functionality to fit my needs. Aside from the potential for duplicate code (which I will have), I discovered that the core functionality that I needed to look at rested in the following subroutine. How many bugs, or potential security holes, can you find?

Note: I have changed some of the information to protect the customer in question, but I have not changed any of the bugs.

sub updateTiles { my $fto = $htmDir . 'tile.htm'; my $content = ''; open(HOME,$fto); while (<HOME>) { $content .= $_ } close(HOME); my $paramTemp,$contentTemp; my @sections = qw(Tile Pile Link); foreach $section (@sections) { $contentTemp = $query->param($section); if ($section eq 'Pile') { $contentTemp =~ s/[\n\r]/<p>/g; } if ($section eq 'Link') { $contentTemp = "<img src=\"images/en +ter.gif\" width=8 height=12><a href=\"cgi-bin/show.cgi?action=showTil +es&tileType=Search&searchFor=$contentTemp\">View this month's tiles.< +/a>" } $content =~ s/<!--$section-->(.*)/<!--$section-->$contentTemp/ +; } open(HOME,">$fto"); print HOME $content; close(HOME); my $image = $query->param('Image'); if ($image ne '') { my $newFile = fileUpload('Image',250000,1,'lat +est_image','JPEG','.jpg','.jpeg') } }

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.


In reply to How many bugs can *you* find by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others drinking their drinks and smoking their pipes about the Monastery: (6)
    As of 2014-09-01 11:30 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      My favorite cookbook is:










      Results (6 votes), past polls