Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

That code can't possibly work! Consider:

my ($sth, $execu); if (!defined ($query)) { $sth->finish ();

$sth is declared, but not initialised. Then if $query is undefined $sth->finish () is called, which must fail with a "Can't call method "finish" on an undefined value at C:\Users\Peter\Delme~~\PerlScratch\noname.pl line 10. " error.

Working a little closer to your issue: passing a query as a string in this fashion without passing parameters for the execute () prevent you from using placeholders which probably means your code is susceptible to insertion attacks.

Which leads to: the code building the query knows which columns are used for the fetched data and has to deal with the returned rows so the problem isn't with the code you've shown - it's with the calling code.

BTW, always use strictures (use strict; use warnings; - see The strictures, according to Seuss).


True laziness is hard work

In reply to Re: DBI : Get Column name and Value in hash by GrandFather
in thread DBI : Get Column name and Value in hash by vinoth.ree

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others musing on the Monastery: (8)
As of 2024-03-28 15:06 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found