You don't have to ask me twice to crack a favorite beverage... done.

I've inherited a lot of crappy code, some of it in Perl (but to be fair, lots more in Java). A few years ago I had to change a script with this code to to add leading zeroes to day and month values less than 10:

sub add_zero { $x = shift; return $x if ( $x > 9 ); return ( '0' . $x 
+) if ( $x < 10 ); }
[download]

I'm not proud of this but I'll admit I "fixed" it with this:

sub pad
{
    my $n = shift;
    return $n if $n =~ /\D/;
    return $n > 9 ? $n : "0$n";
}
[download]

I've never gotten around to fixing that because it always works... so far. But maybe this would be better? (suggestions welcome)

$n = $n =~ /^\d/ ? sprintf('%02d', $n) : $n;
[download]

There is lots more, mostly not mine, some definitely more WTF, but it will take some time to dig through the CVS history and pull out the most entertaining.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.