Hi gang! I just wrote a Hangman script in Perl. It pretty much portrays the extent of my Perl knowledge. This script is just about as good as I am when it comes to Perl, if that makes sense. I'm wondering if you guys can review my code, give me any criticism, inform me of any optimizations I'm missing out on, etc. I don't really care for "Perl golf"-style code, but I do care about optimized, neat code. Readability is important. Thanks in advance! Updated as of 3:11 PM EDT. #!/usr/bin/perl -w
use strict;
open(my $fh, "<", $ARGV[0]) or die "cannot open input file: $!";
my @words = <$fh>;
close $fh or die "cannot close input file: $!";
my $words = @words;
chomp(my $word = lc($words[int(rand($words))]));
my (%correct, $guesses);
my $turns = 8;
while ($turns > 0) {
my $displayed;
foreach my $char (split(//, $word)) {
$displayed .= exists($correct{$char}) ? "$char " : "* ";
}
if (index($displayed, "*") < 0) {
print "\nYou win! You guessed $word!\n";
exit;
}
print "\n$displayed\n",
"Fails remaining: $turns\n",
"Your guesses: $guesses\n",
"Next guess: ";
chomp(my $guess = <STDIN>);
$guess = lc($guess);
if ($guess !~ /[a-z]/ || length($guess) != 1 || index($guesses, $g
+uess) >= 0) {
print "\nInvalid guess.\n";
}
else {
my %word = map { $_ => 1 } split(//, $word);
if (exists($word{$guess})) {
$correct{$guess}++;
}
else {
$turns--;
}
$guesses .= "$guess ";
}
}
print "\nYou lost! The word was $word!\n";
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|