script review

[georgecarlin]

Hi all, is there a section here where I could post a script and have interested/bored people help me improve it? It's working as intended but I would like to escape the "self-taught-nastyness" and improve my overall understanding and scripting style. It is lengthy (alltogether ~1k relevant lines) which is why I didn't post it right away. Apologies if this is the entirely wrong place for something like that.

[CountZero]

And don't forget to add some comments about the purpose of the script, in which environment it will run, any external constraints that apply to it, why you made some design choices, ...

1K lines is long for a script, so perhaps you can split it up into separate logical sections. That will certainly improve your chances the Monks will have a look.

[eyepopslikeamosquito]

A number of attempts have been made to address this problem over the years; for example, Simon Cozens once set up a (now defunct) "code review ladder". At that time, there were more folks wanting reviews than prepared to do them, presumably because performing a detailed, quality code review is very time consuming and few people have the time and inclination to do it.

You might try posting some of your code to the latest attempt at such a site, namely PrePAN. However, before doing that, I suggest you isolate small pieces of code that you're unhappy with and post multiple small questions here to the Seekers of Perl Wisdom section. That way, you will surely get a quick response which you can use to improve and polish your code before submitting to PrePAN, say (if PrePAN is appropriate for your code, which we would be able to advise on).

[Laurent_R]

I don't know if many people will want to go through such a long piece of code, but the very least you should do is to include the code within <readmore>...</readmore> tags.

[talexb]

This is a meta-comment: I believe this post is in the correct section, the discussion section, as it asks to which section a post should be made.

[daxim]

→→→ Meditations is over there →→→

[Anonymous Monk]

→→→ Meditations is over there →→→

For what purpose?

I see Considered: Old_Gray_Bear: Please move to Meditations but meditations is not the place to ask where to post on perlmonks, monkdiscuss (this section) is that place to ask how perlmonks works

Or if you're suggesting meditations as a place to post for code for perlmonks to review, its not, its SOPW, see Where should I post X?

[georgecarlin]

thank you very much.

[Anonymous Monk]

Pragmatically speaking, you need to carve out a small excerpt of your code that represents either a very-focused problem or a very-focused question or RFC, because when most of us do peer-reviews we are being paid for it (and, as such, we're usually quite busy nearly all of the time). Therefore, you need to plan your "pitch" in-advance very carefully so that it can be meaningfully answered and meaningfully-answered quickly. If you do that, you will get your meaningful answer very quickly indeed. (PM is famous for that.)