Re: best practice

[dga]

My tip which seems small but is actually big is use eval blocks for error checking.

Here is an example which happens to use DBI. DBI implements tons to error checking which uses die if you ask it to.

#up top
my $dbh=DBI->connect("DBI:Pg(RaiseError=>1,AutoCommit=>0),dbname=xyzzy
+");

#later
eval {
    my($sth);
    $stmt="SELECT cnam_oficial FROM evocrs WHERE evocrs_id=?";
    $sth=$dbh->prepare($stmt);
    $sth->execute($ec);
    $sth->bind_columns( \( $cn ) );
    $sth->fetch;
    # $dbh->commit; #if we were writing some records instead of readin
+g
};

if($@)
{
    # $dbh->rollback;  #if we were doing transactions and writing data
    print STDERR "Could not retreive course name: $stmt: $@\n";
    print "Could not retrieve course name\n";
    exit;
}

I delclare $stmt in a scope where the eval and the error block can both see it for reporting. The eval saves having to say or die "message" on every line of your code. The RaiseError tells DBI to die on any database error. I put the commit inside the eval as the last line because that will not be reached if there is any problem since a die will jump right out of the eval without doing the rest of the block. The rollback goes in the $@ block which is executed if the eval fails.

This makes your code nice and clean and results in errors being trapped always. The DBI module is very nice about this since RaiseError causes a die for all errors.