Re: subroutine help

A few things to help you out:

Your code doesn't compile, because there is a semi-colon missing at the end of @array = $form =~ /[A-Z][a-z]?|\d+/ig
You assign the result of getweight(), which is in list context, to a scalar. As a result, $weight just equals 6 (the number of elements in the array). If I were you, I'd skip the subroutine and array and make weight a hash directly from the get-go:

#!/usr/bin/env perl
use strict;
use warnings;
use feature 'say';
use Data::Printer;

print "Enter a chemical formula: ";
chomp( my $form = <> );

my %weight = $form =~ /[A-Z][a-z]?|\d+/ig;
p %weight;

__END__

Enter a chemical formula: C12H22O11
{
    C   12,
    H   22,
    O   11
}
[download]

Comment on Re: subroutine help Select or Download Code

Replies are listed 'Best First'.
Re^2: subroutine help by perlguru22 (Acolyte) on Nov 29, 2012 at 08:04 UTC
Sorry I think my kindle modified it and removed the ;	[reply]
Re^3: subroutine help by frozenwithjoy (Priest) on Nov 29, 2012 at 08:12 UTC
Oh, those pesky kindles! (I wonder whatever happened to the 'dog ate my semi-colon' excuse?)	[reply]

In Section Seekers of Perl Wisdom