Re: How do you critique another person's code?

[Juerd]

## yes, the naming convention sucks, but hey, you didn't program it, I did
## come on now, I wrote the code, like there would ever be a problem. he he he

This reminds me of some comment in the MS fdisk source code:

cmd\fdisk\fdisk.c
    /* P.S. - To whoever winds up maintaining this, I will         */
    /*        apoligize in advance. I had just learned 'C' when    */
    /*        writing this, so out of ignorance of the finer points*/
    /*        of the langauge I did a lot of things by brute force.*/
    /*        Hope this doesn't mess you up too much - MT 5/20/86  */

cmd\fdisk\profile.h
    #define BEGIN    {
    #define END      }

I've got to admit the Microsoft programmer did a much better job: he apologized and respected the reader of his source code.
(You might wonder where I got this from - A few months ago, someone gave me a text file with some quotes from the MS DOS 6.0 source code. I can't check if they're genuine, but a google search showed some hits, so I guess it's real.)

BTW, I like the part where the programmer says that those who don't understand his source should not be programming.

2;0 juerd@ouranos:~$ perl -e'undef christmas'
Segmentation fault
2;139 juerd@ouranos:~$