http://www.perlmonks.org?node_id=196063


in reply to Re: Re: Re: Style, style, style
in thread Style, style, style

I regularly see one of these in a co-worker's code:

sub blah { my ( $foo, $bar, $baz ) = ( shift, shift ); }

Perhaps not too bad in a short list of shifts. But terrible when invoked as:

shazam ( 0, 6, 7, $index, $arrayref, $hashref ); ... sub shazam { my ( $foo, $bar, $baz, $bup, $quz, $pig, $cow ) = (shift, shift, shi +ft, shift, shift, shift); }
Quick, was $cow passed in via @_ or simply instantiated?

update: added another egregious example, shazam

blyman
setenv EXINIT 'set noai ts=2'