http://www.perlmonks.org?node_id=272302


in reply to Re^2: Code factory
in thread Code factory

Instead of doing this: 
   push @{$results}, {
    map { $_, $row->{$_} } keys %{$row}
   };

[download]
Wouldn't it be better/faster to just do this: 
   push @{$results}, $row;

[download]
You already have a hash reference, why recreate it?

Replies are listed 'Best First'.
Re: Code factory
by tadman (Prior) on Jul 08, 2003 at 19:01 UTC
    If I recall correctly, DBI recycles the hash reference with each iteration. What you end up with is an ARRAY of exactly the same HASH data. You should duplicate it, as was done with that first bit of code, or better yet:
    push(@$results, { %$row });
[reply]
[d/l]
      No, it does a new hashref every time. At least, this works for me: 
      my @result;
while (my $row = $sth->fetchrow_hashref()) {
    push @result, $row;
}

      [download]
[reply]
[d/l]

      This is a late response since I tend to not pay attention too often.

      DBI recycles arrayref's, but not hashref's. It may be good to make a copy of the hashref just in case that changes in the future though....

[reply]

In Section Seekers of Perl Wisdom