Re: Sort routine runs into infinite loop

[pme]

Hi punitpawar,

I suppose you want to implement bubble sort (http://rosettacode.org/wiki/Sorting_algorithms/Bubble_sort#Perl).

This is a working version of your code.

#!/usr/bin/perl
use strict;


my @array=(12,6,2,9,15);

my ($i,$j,$tmp);

for ($i=0; $i<@array; $i++){

  for ($j=$i+1;$j<@array;$j++){

    if ($array[$j]<$array[$i]){ # '>' reverses the order

      $tmp = $array[$j];
      $array[$j] = $array[$i];
      $array[$i] = $tmp;

    }
  }
}

print "array : @array \n";

[GrandFather]

use strict; helps a whole lot less if you:

my ($i,$j,$tmp);

and actually we are using Perl so you can:

#!/usr/bin/perl
use strict;
use warnings;

my @array = (12, 6, 2, 9, 15);

for my $i (0 .. $#array) {
    for my $j ($i + 1 .. $#array) {
        @array[$j, $i] = @array[$i, $j] if $array[$j] < $array[$i];
    }
}

print "array : @array \n";

If you'd used warnings you'd have caught the error in the process of fixing the warnings.

[hotchiwawa]

So much code...



my @array=(12,6,2,9,15);
foreach (sort { $a <=> $b } @array)
{ print $_, " "; }

[oiskuu]

Most assuredly, your code does not implement bubble sort.

And if we are going to golf it, how about this:

perl -E 'say"2 6 9 12 15"'

[Laurent_R]

So much code...

$ perl -e 'print "$_ " for sort {$a <=> $b} qw {2 6 9 12 15}'
2 6 9 12 15

[hotchiwawa]

yep, always shorter and finishing with a string :pp