Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW

Re: pdb spliting

by ww (Archbishop)
on Feb 02, 2013 at 13:22 UTC ( #1016710=note: print w/replies, xml ) Need Help??

in reply to pdb spliting

This response directs itself to your second question.

Your code passes a syntax check... that is to say, my Perl (5.016) detects no syntax errors.

However, your code suffers from several shortcomings:

  • The "-w" and "use warnings:" are effectively duplicative, in this particular code (ie, where you are not using an external package or module and, thus, where -w's additional effect does NOT propagate to that other code).
  • You are not checking the outcome of your open(...)s. That's a practice that's almost certain to bite you (and, "HARD!").
    1. Instead, you should include a or die "Can't open... $!;" clause that will alert you if your open fails for some reason.
    2. Better yet, use three-argument opens: adopt the above, the use of "<" for read or ">" for writes (BTW, there are other options) and use of a lexical filehandle
      execute perldoc -f open from your OS' command line for details and examples
  • Your "close" commands seems to have fallen out of your code. This, too, can BITE!

Turning to your post, itself:

I know -- off the top of my head -- of at least three diffent ways that the file extension ".pdb" is used -- Palm dbs, C++ debugging, and "Protein Data Bank" data. You really should specify as it's unreasonable to expect the Monks will be able, magicly, to infer which you mean.

And, returning to your second question ("(i)s THIS code is correct...." (sic)) that's easy enough to determine pragmatically: Try it to see. Somehow, I suspect that's not your real question, but, again, you can't expect magic inferences about your actual intent.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1016710]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (4)
As of 2018-06-19 00:14 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (111 votes). Check out past polls.