DESTROY handler changes child exit status?

[saintmike]

I was surprised to find that a DESTROY handler called when an object goes out of scope changes the exit status of the child process it's running in, even if that child exits with exit(exit_code).

This code:

package Foo;
use strict;
use warnings;
sub new {
    bless {}, shift;
}
sub DESTROY {
    warn "$$: destroy";
    system("waaaah");
}

package main;
use strict;
use warnings;
use POSIX ":sys_wait_h";

my $foo = Foo->new();

my $pid = fork();

die "fork failed" if !defined $pid;

if( $pid ) {
    # parent
    print "$$: parent\n";
} else {
    # child
    print "$$: child\n";
    # system("waaaah");
    exit 5;
}

my $reaped = waitpid($pid, 0);

my $child_exit_status = POSIX::WEXITSTATUS($?);

print "pid=$reaped status: $child_exit_status\n";

shows

pid=4778 status: 255

although the child exits with exit(5). So the failing system() call in the DESTROY method of the object that goes out of scope overrides the explicitly set exit() value?

(If you comment out the system() call in the DESTROY handler and uncomment the one in the child code you'll get the expected exit code 5).

Surprised?

[Anonymous Monk]

https://rt.perl.org/rt3//Public/Search/Simple.html?q=DESTROY+Exit -> #30331: system/fork in DESTROY overrides exit code of parent program

Says its a feature, see perlvar#$?

Use  local $?; system ... in DESTROY to overcome it

[Anonymous Monk]

Ha, I'm on win32, using  local $?; reveals a bug in the fork emulation, the effect is opposite of what it should be, using local $? should not cause $? to be used for exit value (which should be the default behavior)

package Foo;
use strict;
use warnings;
sub new {
    bless {}, shift;
}
sub DESTROY {
    warn "$$: destroy";
    local $? if @ARGV;
    system("waaaah");
}

package main;
use strict;
use warnings;
use POSIX ":sys_wait_h";

my $foo = Foo->new();

my $pid = fork();

die "fork failed" if !defined $pid;

if( $pid ) {
    # parent
    print "$$: parent\n";
} else {
    # child
    print "$$: child\n";
    # system("waaaah");
    exit 5;
}

my $reaped = waitpid($pid, 0);
print "reaped( $reaped)  \$?(  $?  ) >> 8  ( @{[ $? >> 8 ]} )\n";

#~ my $child_exit_status = POSIX::WEXITSTATUS($?);
#~ print "pid=$reaped status: $child_exit_status\n";
__END__
$ perl fudge
2060: parent
-3360: child
-3360: destroy at fudge line 8.
'waaaah' is not recognized as an internal or external command,
operable program or batch file.
reaped( -3360)  $?(  0  ) >> 8  ( 0 )
2060: destroy at fudge line 8.
'waaaah' is not recognized as an internal or external command,
operable program or batch file.

$ perl fudge local
1628: parent
-3804: child
-3804: destroy at fudge line 8.
'waaaah' is not recognized as an internal or external command,
operable program or batch file.
reaped( -3804)  $?(  1280  ) >> 8  ( 5 )
1628: destroy at fudge line 8.
'waaaah' is not recognized as an internal or external command,
operable program or batch file.