Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Re: RFC: Code testers/reviewers needed

by hbm (Hermit)
on Jun 07, 2013 at 12:48 UTC ( #1037673=note: print w/replies, xml ) Need Help??


in reply to RFC: Code testers/reviewers needed

Some minor suggestions:

  1. In GetFileSize, change this:
    if ($res->is_success) { my $headers = $res->headers; return $headers; }else{ $flag = 1; $error .= "Error retrieving file information at $url "; } return 0;
    To this:
    return $res->headers if $res->is_success; $flag = 1; $error .= "Error ..."; return 0;
  2. Within your for loop, change this:
    if(exists($extens{$ext})){
    To this, and remove one level of indentation.
    next unless exists $extens{$ext};
  3. Change delimiters rather than escaping. And in this example the global modifier isn't necessary.
    #if($newurl !~ /http::\/\/$/ig){ if($newurl !~ m#http:://$#i){
  4. $skips -= 1; vs. $skips--;?
  5. Change this:
    print"\n\n\n$filename at $newurl\n"; print "File size: ".$header->content_length." bytes\n" unless $flag==1 +; print "Last modified: ".localtime($header->last_modified)."\n" unless +$flag==1;
    To this:
    print "\n\n\n$filename at $newurl\n", printf("File size: %d bytes\nLast modified: %s\n", $header->content_le +ngth, localtime($header->last_modified)) unless $flag == 1;
  6. Spelling and grammar...
    #print"\nExtensions to download (seperated by comma's): "; print"\nExtensions to download (separated by commas): ";

Replies are listed 'Best First'.
Re^2: RFC: Code testers/reviewers needed
by AI Cowboy (Beadle) on Jun 07, 2013 at 22:25 UTC
    Great suggestions all - will definitely make the code more elegant. I haven't coded in Perl for a while, I guess I've forgotten how to make beautiful code :) thanks for the help!

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1037673]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (4)
As of 2021-09-19 09:24 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?