Re^11: Challenge: 8 Letters, Most Words

McA,
My brain is mush so unfortunately, this critique is just the things that jumped out at me.

%alphabet = (%alphabet, map { $_ => 1 } @chars);
[download]

Would be better written as:

@alphabet{@chars} = (); # No need to set values to 1 as you only ever 
+use keys
[download]

I am not sure why you avoid autovivication but


    if(defined $sorted{$characters}) {
        push @{$sorted{$characters}}, $line;
    }
    else {
        $sorted{$characters} = [$line];
    }
[download]

Would work just as well as:

push @{$sorted{$characters}}, $line;
[download]

You waste a lot of time going through loops that you abort early

    foreach (my $pos2 = 0; $pos2 < $count; $pos2++) {
        next if $pos2 < $pos1;
[download]

Would work a lot more efficiently as:

for (my $pos2 = $pos1; $pos2 < $count; $pos2++) {
[download]

I haven't tested it but the way you determine if one is a subset of the other would probably be better as subtracting one hash from another.

Cheers - L~R

Comment on Re^11: Challenge: 8 Letters, Most Words Select or Download Code

Replies are listed 'Best First'.
Re^12: Challenge: 8 Letters, Most Words by McA (Priest) on Oct 05, 2013 at 13:38 UTC
Hi L~R, you're right with all. It is the result of putting code together when it's too late. I let the program run with Devel::NYTProf on a small subset of the dict. The result is what I assumed: Answering the question if a combination of letters is able to produce a word is the most expensive task. I tried to make it faster with a C-like implementation in perl, but it was slower than the hash-approach. The program is still running. Currently at iteration 879000. So, a long time to go... ;-) Anyway, a very very intersting puzzle. And it was fun looking at the different approaches and seeing that some of the "old" monks took that challenge. Best regards McA	[reply]
Re^13: Challenge: 8 Letters, Most Words by Anonymous Monk on Oct 05, 2013 at 17:14 UTC
`Re^12: Challenge: 8 Letters, Most Words` ^12 just seems wrong somehow :)	[reply]
Re^14: Challenge: 8 Letters, Most Words by davido (Cardinal) on Oct 05, 2013 at 17:45 UTC
So does Devel::NYTProf being mentioned in the same thread. :) Dave	[reply]
Re^15: Challenge: 8 Letters, Most Words by McA (Priest) on Oct 06, 2013 at 17:27 UTC


Clear questions and runnable code get the best and fastest answer
	PerlMonks