Re: Style & subroutine organization

[idnopheq]

Unless I'm reading it wrong, options one and two are not equivallent. The first calls 1 then 2 then 3 independent of each other. The second calls 1 which calls 2 which calls 3, 1 dependent on 2 dependent on 3 ( which is missing ).

Part of why subs exist is to ease repetitive tasks w/i code. One applies appropriate style based on need. There will be some instances where option one is best, and others where option two rules.

If you can post a specific example, maybe we can provide a better answer to your somewhat vague question.

HTH
--
idnopheq
Apply yourself to new problems without preparation, develop confidence in your ability to to meet situations as they arrise.

~ Shunryu Suzuki

[camelman]

Sorry about the vague question. All three of these functions would be independent in the sense that they do not pass each other data but I would like to execute them in a row. I meant the execution order in my two options to be equivalent. As silly as it seems, something like this:

#!/usr/bin/perl -w

use strict;

func1();
func2();
func3();

sub func1{
  print "I am the first subroutine\n";
  return 0;
}

sub func2{
  print "I am the second subroutine\n";
  return 0;
}

sub func3{
  print "I am the thrid subroutine\n";
  return 0;
}

[dragonchild]

The way listed here is the canonical way of calling three completely-independent functions in a row. It is very readable and maintainable.

Maintainable, just to go off on a slight rant, is where there are no hidden assumptions. If you were to do:

sub foo1 {
    foo2();
}

sub foo2 {
    foo3();
}

sub foo3{
}

I would assume that foo1() depends on the result of foo2() in some fashion. If it doesn't, then I am very confused. Your piece of hidden information here is that there is no dependence between the function, other than they all need to be executed at the beginning of your script.

If you reduce the amount of information that someone needs to know that cannot be directly deduced from reading the logical structure of your code (you do indent logically, right?), that improves the maintainability of your code. Maintainable code should be your holy grail, above and beyond any other consideration (except for correctness). It should be more important than optimization (save for when business needs demand it).

------
We are the carpenters and bricklayers of the Information Age.

Vote paco for President!