replace deprecated function

[mitchreward]

Hi guys,

I use the following code with a perl v5.14.2, and it tells me that defined function on hash is deprecated. how can I fix this test easily ?

 if (!$Config{'recipient'}) {^M
        if (!defined(%Form)) { &error('bad_referer') }^M
        else                 { &error('no_recipient') }^M
    }^M
    else {^M
...

[Athanasius]

From defined:

Use of defined on aggregates (hashes and arrays) is deprecated. It used to report whether memory for that aggregate had ever been allocated. This behavior may disappear in future versions of Perl. You should instead use a simple test for size:

    if (@an_array) { print "has array elements\n" }
    if (%a_hash)   { print "has hash members\n"   }

Hope that helps,

[choroba]

diagnostics would tell you:

$ perl -E 'defined(%h)' 2>&1 | splain
defined(%hash) is deprecated at -e line 1 (#1)
    (D deprecated) defined() is not usually useful on hashes because i
+t
    checks for an undefined scalar value.  If you want to see if the h
+ash
    is empty, just use if (%hash) { # not empty } for example.

        (Maybe you should just omit the defined()?)

[wjw]

This had me going for a bit too until I found the following in ... of all places... perldoc!

Use of defined on aggregates (hashes and arrays) is deprecated. It used to report whether memory for that aggregate had ever been allocated. This behavior may disappear in future versions of Perl. You should instead use a simple test for size: if (@an_array) { print "has array elements\n" } if (%a_hash) { print "has hash members\n" }

Hope that is helpful...

[mitchreward]

Thanks you guys!

[AnomalousMonk]

See also the discussion recently in response to Code cleanup; how best to deal with: defined(%hash) is deprecated at.... Or, indeed, deprecated defined hash (preloaded) in Super Search (load it yourself).