Re^2: Parsing a file with parentheses to build a hash

[xcellsior]

So, I'm playing with this and it looks like I'm going to use regular expression to break out some of the unique grammer(s) so I can write grammers for each section since they don't all follow the same rules... I'm not sure how to put the info into a hash and I'm getting an error that I don't know how to fix:

#!/usr/bin/perl

use Parse::RecDescent;
use Data::Dumper;

$::RD_ERRORS = 1; #Parser dies when it encounters an error
$::RD_WARN   = 1; #Enable warnings - warn on unused rules &c.
$::RD_HINT   = 1; # Give out hints to help fix problems.

our %DATA;

#my $module_grammar = <<'END_OF_MODULE_GRAMMAR';
  #start : start_module
  #start_module : '(module ' name module_values
  #module_values : '(' section | keypair ')'
  #section : '(' fp_text 
  #keypair : '(' key value ')'
#END_OF_MODULE_GRAMMAR

my $net_grammer = <<'END_OF_NET_GRAMMER';
  start : nets(s)
  nets  : '(net ' node name ')'
  {
    $main::DATA{"NET"}{$item{'node'}} = $item{'name'};
    print "$_\n" for @item{'node'};
  }
  node  : m/\d+/
  name  : m/\S+/
END_OF_NET_GRAMMER

my $text;
open ( BRD, "<attiny84ap.kicad_pcb") or die("ha ha");
while (<BRD>)
{
  my $new_line = $_;
  chomp;
  $text = "$text $new_line";
}

$text =~ s/\s+\(/\(/g; # remove white space in front of '('
$text =~ s/\(\s+/\(/g; # remove white space after '('
$text =~ s/\s+\)/\)/g; # remove white space in front of ')'
$text =~ s/\)s+/\)/g; # remove white space after ')'

# This takes tooooo long silly
#$text =~ m/\(kicad_pcb\(version (\d+)\)\(host pcbnew \"(.*)\"\)\(gene
+ral(.*)\)\(page (\S+)\)\(layers(.*)\)\(setup(.*)\)(\(net .*\))\(net_c
+lass/;
#my $version = $1;
#my $pcbnew_revision = $2;
#my $section_general = $3;
#my $page = $4;
#my $section_layers = $5;
#my $section_setup = $6;
#my $netlist_map = $7;

$text =~ m/^\(kicad_pcb\(version (\d+)\)(\(.*\))\)$/;
my $version = $1;
$text = $2;
#print "D - $version\n";

$text =~ m/^\(host pcbnew \"(.*)\"\)(\(general.*\))$/;
my $pcbnew_revision = $1;
$text = $2;
#print "D - $pcbnew_revision\n";

$text =~ m/^\(general(.*)\)(\(page .*\))$/;
my $section_general = $1;
$text = $2;
$section_general =~ s/\)\(/\)\n\(/g; # put newline between ')('
#print "D - $section_general\n";

$text =~ m/^\(page (\S+)\)(\(layers.*\))$/;
my $page = $1;
$text = $2;
#print "D - $page\n";

$text =~ m/^\(layers(\(.*\))\)(\(setup.*\))$/;
my $section_layers = $1;
$text = $2;
$section_layers =~ s/\)\(/\)\n\(/g; # put newline between ')('
#print "D - $section_layers\n";

$text =~ m/^\(setup(.*\)\))\)(\(net .*\))$/;
my $section_setup = $1;
$text = $2;
$section_setup =~ s/\)\(/\)\n\(/g; # put newline between ')('
#print "D - $section_setup\n";

$text =~ m/^(\(net .*\))(\(net_class.*)$/;
my $netlist_map = $1;
$text = $2;
$netlist_map =~ s/\)\(/\)\n\(/g; # put newline between ')('
print "D - $netlist_map\n";

my $parser = Parse::RecDescent->new($net_grammar) or die "Bad grammar!
+\n";
defined $parser->start($netlist_map) or die "Text doesn't match";

foreach my $KEY (keys %($DATA{"NET"}))
{
  print "$KEY\n";
}

exit;

The file that its calling is in another thread, once I figure out how to link it here I will update this thread. Here is the output I'm getting:

>./parse_kicad_pcb.pl
D - (net 0 "")
(net 1 +9V)
(net 2 /CLK)
(net 3 /DO)
(net 4 /Data_In)
(net 5 /SCL)
(net 6 /SDA)
(net 7 /SET_Horz)
(net 8 /SET_Vert)
(net 9 /~Horz_ON)
(net 10 /~RESET)
(net 11 /~Vert_ON)
(net 12 5V_ATTINY84P)
(net 13 GND)
(net 14 N-000001)
(net 15 N-0000018)
(net 16 N-0000019)
(net 17 N-000002)
(net 18 N-0000021)
(net 19 N-0000024)
(net 20 N-0000026)
(net 21 N-0000027)
(net 22 N-0000028)
(net 23 N-0000029)
(net 24 N-000003)
(net 25 N-0000030)
(net 26 N-0000031)
(net 27 N-0000032)
(net 28 N-0000034)
(net 29 N-0000036)
(net 30 N-0000037)
(net 31 N-0000038)
(net 32 N-0000039)
(net 33 N-0000040)
(net 34 N-0000041)
(net 35 N-0000042)
(net 36 N-0000043)
(net 37 N-0000044)
(net 38 N-0000045)
(net 39 N-0000046)
(net 40 N-0000047)
(net 41 N-0000048)
(net 42 N-0000049)
(net 43 N-0000050)
(net 44 N-000009)
Unknown starting rule (Parse::RecDescent::namespace000001::start) call
+ed
 at ./parse_kicad_pcb.pl line 93.

Any clues that might help? Working on this in 30min chunks isn't helping either, silly other work that needs attention....

[RichardK]

Well, that fragment doesn't compile, $net_grammar doesn't exist. so you didn't get that error message from there ;)

Using strict and warnings will help spot lots of these problems.

But, in general you're trying too hard, you've got to let the parser do what it's best at. It will handle all of that whitespace for you. Just (!) extend you grammar to handle all of the different sections and lets the parser do it's thing.

Maybe you need to review your parser theory and try out some simple examples first to get the hang of how RecDecent works. It is big and complex, and I don't use it often enough to keep all of the details in my head. I always have to experiment around a bit to get it to do what I want.

Have Kicad published a formal grammar for their file format? It's worth a look anyway.