Re: Sort alphabetically from file

[james28909]

Using Hash of Arrays, is simple enough.

use strict;
use warnings;

my %hash;

while (<DATA> =~ /(\d)\s+(\d)\s+(\d)\s+(\w+)/){
push @{$hash{$4}}, $1, $2, $3;
}

print "@{$hash{$_}}[0..2] $_\n" for sort keys %hash;

__DATA__
1  2  3  delta
1  2  3  apricot
1  2  3  charlie
1  2  3  bravo
1  2  3  echo
1  2  3  fox

EDIT: changed up code slightly

[edujs7]

Original contents:

thanks I tried the below and no errors but nothing happens, sure it's me though.

if ($ARGV[0] eq "-a") {
   open (INFILE, "$ARGV[1]") or die "$ARGV[1] cannot be openned : $!";
   my %hash;
   while ($source_file =~ /(\d)\s+(\d)\s+(\d)\s+(\w+)/) {
       push @{$hash{$4}}, $1, $2, $3;
   }
   print "@{$hash{$_}}[0..2] $_\n" for sort keys %hash;
}

BTW I should've mentioned I must call my program as follows: myprogram.pl($ARGV[0]) option($ARGV[1]) mytextfile.txt($ARGV[-1]) I'm using this for assigning the text file to a variable $source_file = "$ARGV[-1] hence using $source_file to call the text file but now working. am I missing something?

---

Thanks - will try this out. :)

2019-06-17 Athanasius restored original contents and added code tags around the program call

[soonix]

• open (INFILE, "$ARGV[1]") or die "$ARGV[1] cannot be openned : $!";
  while ($source_file =~ /(\d)\s+(\d)\s+(\d)\s+(\w+)/)
  

  Maybe (probably) in your head there's a connection between INFILE and $source_file, but not in your script.
  For Perl, they're unrelated…

• if ($ARGV[0] eq "-a")
  

  How do you know your $ARGV[0] really equals "-a"?
  What happens if it doesn't?
  I recommend to add an else block with a print "whatever\n", at least while you're still experimenting.
• Many of the suggestions to your questions include using strict and warnings. Although this seems to impede or slowing down one's development, I recommend it, too:
  • Yes, the time it takes before your script "runs", will be longer
  • The time until your script works correctly, will be shorter
  One of strict's messages is confusing for beginners:

  Global symbol "$x" requires explicit package name

  should read

  Do you really want "$x" to be a global symbol? Better declare it with my

If you are new to Perl, you might like diagnostics, which won't throw more errors, but messages that (hopefully) are more informative. So, your script(s) should start with

use strict;
use warnings;
use diagnostics;

[edujs7]

noted. Thank you very much for your support.

[bliako]

It is better to open the file using open INFILE, "<", $ARGV[1] or, even better, open $inFILE_HANDLE, "<", $ARGV[1]. It is not causing you a problem now because open() opens for reading (called the "mode") without explicitly setting mode (e.g. reading: "<")

There is a problem reading the file. First you open a file using open(), for that you get a fileHANDLE, e.g. the INFILE or $inFILE_HANDLE. Then you loop reading from the FILE-HANDLE using the diamond operator while(<$inFILE_HANDLE>){ print $_ } and then you close the file(HANDLE): close $inFILE_HANDLE;. You can't read any file contents from a variable which just stores the fileNAME.

In the case your input is not unique wrt the fourth column you will miss input, all similar column-four lines will go to the hash keyed on column-four overriding any previous line with same column-four key. One solution is not to use a hash but an array of arrays (these are formed in exactly the same way as you do now with the regex) and sort works on arrays.

See Re^3: Sort alphabetically from file and Re^3: Sort alphabetically from file, they already gave you hints for file open/read problems.

[LanX]

> In the case your input is not unique wrt the fourth column you will miss input,

That's my biggest problem with this hash approach! Thanks for pointing it out. :)