http://www.perlmonks.org?node_id=11102783


in reply to Re: perl script to compare two directories
in thread perl script to compare two directories

I don't have enough time to go through all of the code right now, but I do see quite a few reinvented wheels, as has been discussed before, for example, I've pointed you to File::Spec before. Reinventing wheels gives you more code to maintain, more code to test, and more chances to introduce bugs. For example, toNicePath is incorrect: a backslash \ is a valid character in *NIX filenames. Getting portability right is tricky, which is why modules like File::Spec exist in the first place.

I strongly recommend you take the time to study what modules are available to you, especially what core modules, as those are (almost) always installed.

Replies are listed 'Best First'.
Re^3: perl script to compare two directories
by afoken (Canon) on Jul 14, 2019 at 00:46 UTC
    I've pointed you to File::Spec before. Reinventing wheels gives you more code to maintain, more code to test, and more chances to introduce bugs.

    I fully agree to use modules instead of re-inventing the wheel, poorly.

    BUT: File::Spec is one of the modules that have a conceptual error, probably since the first version. See:

    Even with that error, it is better than re-inventing the wheel.

    Alexander

    --
    Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)