Re: Popping from method that returns a list in one line

[jcb]

You cannot pop the return value of ->get_files because it is not an array.

pop @{[$fp->get_files]}

That should work, but should make the uselessness of this obvious: it constructs an array from the list returned by ->get_files, removes the last value from that array, and then throws the entire array away.

If this is part of File::Collector, I do not see a way for ->get_files to do what you seem to want, although you could add a ->get_file_queue method that returns a reference to the current file queue for a category. If I understand correctly, this would be return $s->{"_iterator_$type"} (but you should probably change your instance variables to make that return $s->{iterators}{$type} instead).

[BillKSmith]

You cannot pop the return value of ->get_files because it is not an array.

For an explanation of why this makes a difference, see the FAQ:

perldoc -q "What is the difference between a list and an array"

The Synopsis section of the documentation pop specifies that it requires an array.

[nysus]

Thanks. I was just writing a quick and dirty test for the module and ran across this issue.

ok $fp->get_data(pop @{($fp->get_parseable_files)}), 'can get data from file';

[shmem]

which prolly should be

ok $fp->get_data(pop @{[$fp->get_parseable_files]}), 'can get data fro
+m file';

[AnomalousMonk]

Or maybe (untested):
    ok $fp->get_data(($fp->get_parseable_files)[-1]), 'can get data from file';