Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re^4: Automating execution of shell scripts

by wisely (Initiate)
on Sep 20, 2021 at 07:51 UTC ( #11136867=note: print w/replies, xml ) Need Help??


in reply to Re^3: Automating execution of shell scripts
in thread Automating execution of shell scripts

Sorry I forgot to mention this was only a snippet of the whole program, and it wasn't exactly accurate to what I had in actual program.
I just wanted to illustrate what the direction in which I was headed for solving this.
Sorry also that I couldn't just paste the whole code.
Anyway in my actual program it turned out that the issue was the scope of the $dir variable in my subroutine as far as I can tell.
The program works correctly now.
I guess it would be better (also faster?) if it is done in the main program and not in a subroutine, but it was easier for me to follow what I am doing by writing subroutines. I am also not sure how to do what you mention.
  • Comment on Re^4: Automating execution of shell scripts

Replies are listed 'Best First'.
Re^5: Automating execution of shell scripts
by AnomalousMonk (Bishop) on Sep 20, 2021 at 18:33 UTC
    I guess it would be better (also faster?) if it is done in the main program and not in a subroutine ...

    A highly questionable guess IMHO. Reasonable factoring of code into subroutines certainly has the benefits of increased clarity and maintainability, encapsulation, etc., as you mention. The only speed advantage of inlining might be in a case in which you are calling a relatively simple function a gazillion times in a program. In the typical case, Perl call-return overhead vanishes into the background of a script.

    (And yes, please see Short, Self-Contained, Correct Example.)


    Give a man a fish:  <%-{-{-{-<

      Hi Bill and AnomalousMonk,
      I will make sure to review this and keep it in mind for the next time I need help on some code and come back to post here.
      In any case thank you all for the help with resolving the issues with the code.
      Cheers guys!
Re^5: Automating execution of shell scripts
by BillKSmith (Monsignor) on Sep 20, 2021 at 16:09 UTC
    We almost never want your complete program. The code that you extract should be made into a complete program which includes enough data that we can run it and duplicate your problem. This can be harder than it sounds. Often this is exactly what you need to solve the problem yourself. I suspect that this is what happened to you.
    Bill

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://11136867]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (2)
As of 2022-05-21 07:26 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Do you prefer to work remotely?



    Results (76 votes). Check out past polls.

    Notices?