Re: help with splitting and printing the array

[blindluke]

Hello, perlnewbie012215, welcome to the Monastery.

First of all, start using use strict; use warnings; This would help you with the mistake of storing localtime in $datestring and trying to print $date.

Your biggest problem is the fact that you are splitting the log line into words (roughly), and you are counting that the server1.prod.com will be the sixth word. You already know what happens if some additional parameters show up before the server name - the count is off. But what happens when someone switches the order of parameters? Try using a regular expression to match the specific parameters, and not counting which word is the server name.

UPDATE:

Take a look at this small script operating on your sample data. This should hopefully set you on the right track.

#!/usr/bin/perl
use warnings;
use strict;

while(<DATA>) {
    chomp;
    my $servname = '[a-z0-9]+\.[a-z0-9]+\.[a-z0-9]+';
    /-S.+?($servname).+-D.+?($servname).+-C.+?($servname).+$/;
    print "Server after -S: $1; Server after -D: $2; Server after -C: 
+$3;\n";
}

__DATA__
18:06:04.616 79952.57692 <2> logparams: -S server1.prod.com -D server2
+.prod.com -C server3.prod.com -X -s 1421467204 -e 1421467204 -R E:\Pr
+ogram Files\725635\logs\log.tmp.chg -K -t 13 -M -k -L E:\Program File
+s\725635\logs\infod.tmp.log -W -f E:\Program Files\725635\logs\after.
+tmp
17:49:34.216 58140.81564 <2> logparams: -S -l -a -k server1.prod.com -
+D client10.prod.com -C sql12.prod.com -X -s 1421467205 -e 1421467205 
+-R E:\Program Files\561234\logs\log.tmp.chg -K -t 13 -M -k -L E:\Prog
+ram Files\561234\infod10.tmp.log -W -f E:\Program Files\561234\logs\a
+fter.tmp

The output:

Server after -S: server1.prod.com; Server after -D: server2.prod.com; 
+Server after -C: server3.prod.com;
Server after -S: server1.prod.com; Server after -D: client10.prod.com;
+ Server after -C: sql12.prod.com;

[pme]

After splitting the line you can simply get rid of the fields starting with '-' and then print the appropriate array elements.

while (<DATA>) {
  chomp;
  my @line = grep {!/^-/} split;
  print $line[0], ' ' , $line[4], "\n";
}

[blindluke]

And how will that help when someone switches the order of parameters? In my reply, I've stated that there are two big problems with the split approach. OP already encountered the first one, but your proposed solution won't save him from the second. Relying on the order of commandline parameters is a wrong approach here.

[pme]

Hi Luke,

It doesn't help, it is just a simpler solution. perlnewbie012215 says about 20 lines hence a simple solution might do the job as well.

BTW your code can be improved by checking the regexp match because it prints out the previous line if the pattern doesn't match:

if (/-S.+?($servname).+-D.+?($servname).+-C.+?($servname).+$/) {
    print "Server after -S: $1; Server after -D: $2; Server after -C: 
+$3;\n";
} else {
    print "Unknown record structure: $_\n";
}

Or the important command line switches could be checked one by one and add them to the output if they exist.

[perlnewbie012215]

Thank you Luke!! That helped me out alot.