Re: Passing a hash plus some strings to a subroutine

[hippo]

It's just moaning about your use of individually shifting the args. This passes perlcritic --stern for me:

sub generate {
    my ($record, $status, %data) = @_;
    return;
}

[ikegami]

Nothing wrong with shifting. Easier to provide defaults and comments. And then there's the newish signature feature. Take perlcritic's critiques with a grain a salt, and adjust them to your liking.

[LanX]

Not the same thing tho.

The OP is passing a hashref, but you are un- and repacking a hash as list of keys and values.

[Anonymous Monk]

Why does perlcritic complain about this:

my %arg = @_;

Always unpack @_ first...

[hippo]

It does not complain about that. Here is my SSCCE showing as such:

$ cat x.pl 
#!/usr/bin/env perl
use strict;
use warnings;
use utf8;

sub foo {
    my %arg = @_;
    print "Woo!\n";
    return;
}

foo (z => 3);
$ perlcritic --stern x.pl
x.pl source OK
$

This suggests that the cause of its complaint (if any) is in the code which you have not shown, such as if you have done something in the sub before that line and hence that line is not "first".

[Anonymous Monk]

> you have done something in the sub before that line and hence that line is not "first"

Thank you hippo! That is exactly the case. Why is that not a PBP? I have good reasons for putting code before dealing with parameters in subs, like using IPC::Cmd to check if we can run an executable:

sub something {
  return 'oops' unless can_run('something');
  my %arg = @_;
  ...
}