expect.pm header

[amagana]

I am needing help with trying to insert a header for each server that gets the password changed in this script. I think I need a log file to identify where the script failed. But I am not able to get a header as recommended. I am getting this error: Global symbol "$system" requires explicit package name at ./tester-a line 7. Execution of ./tester-a aborted due to compilation errors. I am trying to insert a header into a log file for each server but I am just not able to get it to work,

#!/usr/bin/perl
use strict;

use Expect;

my $timeout = 60;
my $header = "\n\n======= $system =======\n"; 
my @servers = qw(
    Solaris-host
    Solaris-host
    Solaris-host 
    Solaris-host
);


for my $server (@servers) {
# do your thing with $server

    change_password($server);

 }

sub change_password {
            my $system = shift;

my $filename = "/var/tmp/expect_script.log"; 
my $ssh = Expect->new('ssh amagana@' . $system);



$ssh->debug(1);
$ssh->expect ( $timeout,
      [ qr/Password:/],
      [ qr/Are you sure you want to continue connecting \(yes\/no\)?/]
      );

if ($ssh->match() =~ m/Are you sure you want to continue connecting \(
+yes\/no\)?/)

 { 

$ssh->send("yes\r"); 

  }

elsif ($ssh->match() =~ m/Password:/ ) {

$ssh->send("mycurrentpassword\n");

}


$ssh->expect(60, '$');
$ssh->print_log_file($header);
$ssh->send("su - root\n");
$ssh->expect(60, 'Password:');
$ssh->send("rootpassword\n");
$ssh->expect(60, '#');
$ssh->send("passwd amagana\n");
$ssh->expect(60, 'New Password:');
$ssh->send("mynewpassword\n");
$ssh->expect(60, 'Re-enter new Password:'); 
$ssh->send("mynewpassword\n");
$ssh->expect(60, '#'); 
$ssh->close(); 
}

[roboticus]

amagana:

The error message says "line 7", and on line 7 you have a variable ($system) that has never had a value in it. Delete that line, and you should be able to move further in.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

[amagana]

Hello roboticus, I really wanted to have a header but you are right the $system does not have a value assigned to it. Looking at my script how can I get $system to be in my log that corresponds to each server getting the password changed. That is what I am trying to do. Respectfully,

[GotToBTru]

You need to replace $system with a placeholder - it could be the word 'system' - and then, just before you print the header, use s/// to replace the placeholder with the value you want, which will be defined at that time.

my $header = "\n\n======= system =======\n";
...
sub change_password {
  my $system = shift;
  $header =~ s/system/$system/;
...

[stevieb]

$system, used in your header way at the top is never defined at all, let alone before it is used.

You need to re-evaluate how you are doing things. It looks like you want to create a header down after you define @systems, then iterate over that through each one and use something like

"---$system[N]---\n".

Also,

use warnings;

...might have been useful, but I didn't test. Always use it.

-stevieb

[amagana]

You are right, I am a novice and need help if you could give me an example, I would be greatful.

[stevieb]

Just do what our friend roboticus said in his above post :)

-stevieb