Re: One-shot code critique

This is an archived low-energy page for bots and other anonmyous visitors. Please sign up if you are a human and want to interact.

A couple of things, first is just a matter of preference, but on this:

open FILE, "$dir\\$file" or die "Can't open $dir\\$file: $!";
[download]

I find the double backslashes ugly, and on Windows you can pretend you have a Unix file system, and just use a single forward slash, which looks alot better IMHO.

Second, correct me if I'm wrong, but I don't see any variables in your $target, $target2, or $replace variables, which makes them constant strings, and as such I would define them outside the loop, and on your substitution statement I would use the '/o' modifier (see perldoc perlre).

Last, you're checking the status of your opendir and your first open, which is good, but your not checking the status of your lastopen, which is bad.

Update: Also, use 'here docs', e.g.:

my $target = <<ENDHTML;
<html>
<head>
<title>[^>]*</title>
<meta
 http-equiv="Content-Type" content="text/html;charset=iso-8859-1">
</head>
<body bgcolor=["]#FFFFFF["]>
ENDHTML
[download]

Comment on Re: One-shot code critique Select or Download Code

• hippo

‥ epoptai's answer Re: how do I set a cookie and redirect was blessed by hippo!

• erzuuli

‥ Anonymous Monks are no longer allowed to use Super Search, due to an excessive use of this resource by robots.


Perl-Sensitive Sunglasses
	PerlMonks