Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Re: naming anonymous subroutines inner variables

by runrig (Abbot)
on Jun 22, 2016 at 21:43 UTC ( #1166313=note: print w/replies, xml ) Need Help??


in reply to naming anonymous subroutines inner variables

Seems a waste to copy the sql from, e.g., $self->{SQL}->{test} to $self->{test}, and I would assume $self is already a closure, so you shouldn't need to pass it to the sub, and the sth itself can be a closure and so not stored directly in $self, so I might go with:
for ( keys %{$self->{SQL}} ) { my $name = $_; my $dbh = $self->{DBO}; my $sth = $dbh->prepare($self->{SQL}{$name}; $self->{STH}{$name} = sub { my @res; $sth->execute(@_); while (my $dbrow = $sth->fetchrow_hashref()) { # Not sure why you're making a reference to a hashref here push @res, \$dbrow; } return \@res; }; }
And if you don't need to have references to hashrefs in the arrayref, then the execute() and the while loop can be replaced with:
my $res = $dbh->selectall_arrayref($sth, {Slice => {}}, @_); return $res;
Or even (only $sth needs to be a closure):
return $sth->{Database}->selectall_arrayref($sth, {Slice => {}}, @_);

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1166313]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (6)
As of 2019-04-24 13:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I am most likely to install a new module from CPAN if:
















    Results (122 votes). Check out past polls.

    Notices?