Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re: form parsing

by merlyn (Sage)
on Oct 09, 2001 at 18:01 UTC ( #117736=note: print w/replies, xml ) Need Help??


in reply to form parsing

Your code won't work, and neither will any of the responses so far, for the simple matter that $cgi->param doesn't return an lvalue!

Try this instead:

for my $p (qw(field1 field2)) { local $_ = $cgi->param($p); s/\*//g; # or tr/*//d; $cgi->param($p, $_); # set it back }

-- Randal L. Schwartz, Perl hacker

Replies are listed 'Best First'.
Re (tilly) 2: form parsing
by tilly (Archbishop) on Oct 09, 2001 at 19:24 UTC
    Now that we have somewhat functional code, it is still broken for two reasons.

    The first has to do with CGI's attempts to overload the param function with every possible behaviour. What happens if your form has an input variable named "-name"?

    The second has to do with Perl's list versus scalar context. What happens if your form sent back multiple values with the same name?

    Here is more robust code, using the functional interface (easily translated into the OO interface):

    foreach my $name (param()) { my @values = param($p); s/\*//g foreach @values; param( -name=>$name, -values=>\@values ); }
    And people wonder why I prefer to avoid creating highly magical polymorphic interfaces? Note between merlyn and myself in 8 lines of code, with 5 different invocations of the param function, no two of them used the same part of the possible interface! (This is even true if you don't count the OO vs functional invocation issue.) People handle context pretty well, true, but there is a limit beyond which people start having problems. And when you mess up for this reason, it isn't very obvious that you did mess up, or what you did wrong!

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://117736]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (2)
As of 2018-12-19 01:46 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    How many stories does it take before you've heard them all?







    Results (83 votes). Check out past polls.

    Notices?