Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re: Colour/color sampler

by Athanasius (Chancellor)
on Aug 20, 2017 at 14:00 UTC ( #1197700=note: print w/replies, xml ) Need Help??

in reply to Colour/color sampler

Hello Nige,

Thanks for that, it looks useful.

A few minor points:

  • Although your code is, in fact, strict-compliant, it would be better to make this explicit with use strict;
  • Since you’re not using the list returned by map, it would probably be clearer to use a for loop here:
    s/^(0x|#)(.{6})/$2/ for @hexSs;
  • The statement print "</TR>\n</TR>" is probably meant to be print "</TR>\n<TR>" (i.e. ending the last table row and beginning another)
  • When comparing numbers, use > rather than gt (which is for stringwise comparison)
  • Although the comparison is with 4, the logic actually prints 6 cells per row. I think the following is clearer:
    my $cell = 0; for my $hex (@hexSs) { print "<TD BGCOLOR='#$hex'>", "<FONT COLOR='white'>$hex</FONT><BR /><BR />", "<FONT COLOR='black'>$hex</FONT></TD>"; if (++$cell >= 6) { $cell = 0; print "</TR>\n<TR>"; } }

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1197700]
talexb finishes writing a Cranky Old Man post, and hopes it will be taken in the spirit intended. :)
[Corion]: We're happy to have you here, talexb!
[talexb]: Thanks. :)

How do I use this? | Other CB clients
Other Users?
Others examining the Monastery: (9)
As of 2018-07-19 14:15 GMT
Find Nodes?
    Voting Booth?
    It has been suggested to rename Perl 6 in order to boost its marketing potential. Which name would you prefer?

    Results (409 votes). Check out past polls.