in reply to Perl program to search files

Hello harangzsolt33,

One thing I notice is that your sub RSPACE is essentially duplicating part of the functionality already present in Perl’s printf and sprintf builtin functions. In fact, your functions RSPACE and PRINT can be removed altogether, and the two places where PRINT is called can be written as follows:

# (1) in sub SearchFile: PRINT("FOUND: $FULLNAME"); # original printf " %-8dFOUND: %s\n", $TOTAL, $FULLNAME; # replacement # (2) in sub CheckDIR: if ($VERBOSE) { PRINT("SEARCHING: ", FormatPath($PATH)); } + # original printf " %-8dSEARCHING: %s\n", $TOTAL, FormatPath($PATH) if $VERBOSE; + # replacement

Note the use of a statement mofifier in the second case. In general, statement modifiers should be preferred over compound statements whenever a single statement is involved, as this simplifies the code.

Some of your coding conventions could also be improved (IMHO):

I haven’t studied your code in detail. Overall, it looks good: well thought-out and implemented.

Regarding posting:
(1) It would be better to include your code in the question itself (inside <readmore> tags!) than to provide a web address, as the latter is likely to become invalid and so render this thread incomprehensible to future readers.
(2) You say you have tested the program. Adding your test code (again, in <readmore> tags, of course) would aid the monks in evaluating your code.

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,