Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things

Re: Would you use 'goto' here?

by chipmunk (Parson)
on Dec 06, 2001 at 05:54 UTC ( #129828=note: print w/replies, xml ) Need Help??

in reply to Would you use 'goto' here?

I'm curious why it is that you don't have the dispatch code check the office id, as well as the action and type, so that you can call the desired subroutine directly.

I think that it's just as well not to use goto in this case.

Replies are listed 'Best First'.
(Ovid) Re: Re: Would you use 'goto' here?
by Ovid (Cardinal) on Dec 06, 2001 at 06:17 UTC

    Just to give you a taste of what I am doing and why, here's a (heavily edited) version of the dispatch code.

    my %page_control = ( edit => { product => { page => 'ps-main-product-edit.tmpl', function => \&edit_product }, }, default => { page => 'ps-main.tmpl', function => '' } ); # not worried about auto-vivification because false entries will g +o to defaults my ( $page, $function ); if ( $action and $type ) { $page = $page_control{ $action }{ $type }{ page }; $function = $page_control{ $action }{ $type }{ function }; } $page ||= $page_control{ default }{ page } my $permissions = $sec->get_permissions( $section ); if ( $action and $page =~ /^$secured/ ) { if ( exists $page_control{ $action } and exists $page_control{ $action }{ $permType } and ! $permissions->{ $type }{ $action } ) { my $article = $type =~ /^[aeiouAEIOU]/ ? 'an' : 'a'; $sec->force_logout( "$user tried to $action $article $type +." ); } } # call correct function my ( $template_data, $new_page ) = $function->( $query, $db, $mod, + $sec ) if defined $function and $function; $page = $new_page if defined $new_page and $new_page; $template->process( $page, $template_data ) or dienice $template-> +error();

    Basically, I use the hash to assign pages and functions for each action (permission) and type (section). We then call the function with all the data that it will need and it returns template data and, if necessary, a new page to send the user to. All functions have the same inputs and outputs.

    The problem, as I see it, is how the permissions model is set up to prevent people from gaining access to something that they shouldn't. If I start building in a bunch of special cases into the dispatch code, I'm concerned that now, or in maintenance, we'll overlook something in the security portion. Since that's relatively stable, I really want all changes to occur after security has been nicely wrapped up.


    Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://129828]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (3)
As of 2021-07-28 21:43 GMT
Find Nodes?
    Voting Booth?

    No recent polls found