Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Re: How do you critique another person's code?

by hsmyers (Canon)
on Dec 20, 2001 at 01:35 UTC ( #133271=note: print w/replies, xml ) Need Help??

in reply to How do you critique another person's code?

It occurs to me that at least one thing you might want to do is to determine whether the programmer is 'friend' or 'foe'. All of the advice given so far will still have to take this small fact to account. If this were an ideal world, things might be different, but just the existence of such code suggests that there is a significant problem lurking in your organization. You might also do well to find out what backing this person has, I assume that he or she must have some, how else to explain this sort of mess? Actually the more I think about it, the more I think that this isn't a coding problem, this is an office politics problem. I suppose to be generous, the code and the person involved might be remedied, but such an investment might well cost more than it's worth.

Tactically speaking, I would assume the role of 'The Fool with Questions'. Essentially, have the programmer explain all of the anomalies you've found, to you, because you—of course, just don't understand. This way, the onus is one the author to either save themselves or not.

And if things truely get ugly, be prepared and bring copies of your node and the responses to it to the meeting! Just a thought!


"Never try to teach a pig to sing…it wastes your time and it annoys the pig."
  • Comment on Re: How do you critique another person's code?

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133271]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (6)
As of 2019-09-20 02:22 GMT
Find Nodes?
    Voting Booth?
    The room is dark, and your next move is ...

    Results (253 votes). Check out past polls.