get the best and fastest answer
|
|
|
|
Clear questions and runnable code get the best and fastest answer |
|
| PerlMonks |
Re: How do you critique another person's code?by chromatic (Archbishop) |
| on Dec 19, 2001 at 22:01 UTC ( [id://133312]=note: print w/replies, xml ) | Need Help?? |
This is an archived low-energy page for bots and other anonmyous visitors. Please sign up if you are a human and want to interact.
If I were you, I would rewrite the sections in question. I might say something like, "The existing code relies on side effects and undocumented assumptions. It is fragile and could be made more clear. Here is my suggestion for an improvement."
If you lay them out side by side, it'll be obvious... assuming the other people know sufficient Perl. I'd leave the issue of comments alone. Again, assuming the other people have a decent grasp (graps?!) of the English language, they'll likely come to the same conclusion you did without having to be told how to feel about them. If you're in a politically charged position, you may be better off leading people to your opinion than presenting it as an opposing position -- especially if the existing code is already in place and doing its job. (For what it's worth, the only problem I have with the substr code is the need to assign to $_. That's useless.)
In Section
Meditations
|
|
||||||||||||||||||||||||