Re: Re: Re: Just Another Lotto Script

Sorry, I missed your comments in the code.

Well, of course the two short answers are "if it works..." and "TMTOWTDI". I guess neither of those are what you're looking for.

In general, there is nothing wrong with what you did. One style point though: when you open a file, always check that it completed successfully:

open HTML, ">html.txt" or die "couldn't open html.txt: $!\n";
[download]

Writing it to a file is a good idea, at least in development stages, that way you know what you've got. Would you rather not write the html file? You could "stringify" @html, if no other way than with a foreach loop:

foreach my $line (@html) {
    $html .= $line;
}
[download]

Seem reasonable?

Scott

Comment on Re: Re: Re: Just Another Lotto Script Select or Download Code

Replies are listed 'Best First'.
Re: Re: Re: Re: Just Another Lotto Script by Juerd (Abbot) on Mar 06, 2002 at 16:56 UTC
If you want to concatenate all elements of a list, use the function that was made to do exactly so: join. `my $html = join '', @html;` [download] ++ vs lbh qrpbqrq guvf hfvat n ge va Crey :) Nabgure bar vs lbh qvq fb jvgubhg ernqvat n znahny svefg. -- vs lbh hfrq OFQ pnrfne ;) - Whreq	[reply] [d/l]
Re: Re: Re: Re: Just Another Lotto Script by draper7 (Scribe) on Mar 06, 2002 at 17:10 UTC
Yeah, thats what I was looking for. ## i shouldn't do this, should i? # #open(HTML,">html.txt"); #print HTML @html; #close(HTML); my $html; foreach my $line (@html) { $html .= $line; } ## extract table info from array # my $extract = new HTML::TableExtract( headers => ['Date','Numbers'] ); my $ts; my $row; undef $/; ## help? # #open(HTML, "html.txt"); #my $lotto = <HTML>; #close(HTML); open(NUMBERS, ">c4_numbers.txt"); ## changed $lotto to $html $extract->parse($html); foreach $ts ($extract->table_states) { foreach $row ($ts->rows) { print NUMBERS join(":", @$row), "\n"; } } close(HTML); close(NUMBERS); [download] --JD	[reply] [d/l]


Think about Loose Coupling
	PerlMonks