Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?

Re2: Extreme Example of TMTOWTDI

by dragonchild (Archbishop)
on Mar 22, 2002 at 16:41 UTC ( #153597=note: print w/replies, xml ) Need Help??

in reply to Re: Extreme Example of TMTOWTDI
in thread Extreme Example of TMTOWTDI

open(OUTPUT,">>${len}.words"); while(<>){ chomp($_); $len = length($_); print OUTPUT "$_\n"; } close(OUTPUT);
This doesn't do what the others do. For one, $len isn't defined before the open. Secondly, you don't have an outer loop involved to be able to re-open the files as needed.

Secondly, if you're going to use $_, then use it. Don't piddle around. If you're going to use a named variable (and I'm not saying this is bad), then name it. Otherwise, take advantage of Perl-isms.

while (<>) { chomp; my $len = length; print OUTPUT $_, $/; }
It wouldn't be nice unless I posted my own (unBenchmarked) version.
use IO::File; my %Handles; while (<>) { my $handle = $Handles{length} ||= IO::File->new(">" . length - 1); print $handle $_; } # This is unnecessary unless you're anal (like I try to be) $_->close for values %Handles;

We are the carpenters and bricklayers of the Information Age.

Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://153597]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (5)
As of 2020-02-17 09:32 GMT
Find Nodes?
    Voting Booth?
    What numbers are you going to focus on primarily in 2020?

    Results (71 votes). Check out past polls.