Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

Re: Marge - the Interactive Marginalia Processor

by thraxil (Prior)
on Jul 08, 2002 at 21:33 UTC ( #180332=note: print w/replies, xml ) Need Help??

in reply to Marge - the Interactive Marginalia Processor

a few things:

  1. use CGI; this is of supreme importance.
  2. use strict; and -w
  3. taint checking. using -T would inform you that you are doing some very dangerous things using code like open(MARGE,">$pageroot.marge") where $pageroot just comes straight in from a parameter without any kind of scrubbing.
  4. the code would be much more readable if the HTML were seperated out via some kind of templating system like HTML::Template.
  5. code like if("$link" eq "some string") is bad. perl will treat $link as a string automatically; quoting it serves no purpose.

anders pearson

  • Comment on Re: Marge - the Interactive Marginalia Processor

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://180332]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (8)
As of 2022-01-17 10:15 GMT
Find Nodes?
    Voting Booth?
    In 2022, my preferred method to securely store passwords is:

    Results (51 votes). Check out past polls.