http://www.perlmonks.org?node_id=180332


in reply to Marge - the Interactive Marginalia Processor

a few things:

  1. use CGI; this is of supreme importance.
  2. use strict; and -w
  3. taint checking. using -T would inform you that you are doing some very dangerous things using code like open(MARGE,">$pageroot.marge") where $pageroot just comes straight in from a parameter without any kind of scrubbing.
  4. the code would be much more readable if the HTML were seperated out via some kind of templating system like HTML::Template.
  5. code like if("$link" eq "some string") is bad. perl will treat $link as a string automatically; quoting it serves no purpose.

anders pearson